REF: dont pass fill_value to algos.take_nd from internals.concat #39446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 28, 2021
| def _get_default_fill_value(dtype, fill_value): | ||
| if fill_value is lib.no_default: | ||
| if is_extension_array_dtype(dtype): | ||
| fill_value = dtype.na_value |
There was a problem hiding this comment.
thats what i thought too, but its behavior is slightly different
jreback
added
Missing-data
This was referenced Jan 29, 2021
jreback
approved these changes
Feb 1, 2021
|
thanks |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dtype-finding code in internals.concat is something else. Tried untangling it, but now I think we can make it unnecessary altogether. This is the first step in that process.